#76 logger n #78
Merged
#76 logger n #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - requires `@shiftcode/logger@^4.0.0` - ConsoleLogTransport renamed to BrowserConsoleLogTransportService and using its own config `BROWSER_CONSOLE_LOG_TRANSPORT_CONFIG` - NodeConsoleLogTransport renamed to NodeConsoleLogTransportService and using its own config `NODE_CONSOLE_LOG_TRANSPORT_CONFIG`
…chApi construct - CloudWatchLogServiceV2 - CloudWatchLogConfigV2 - CloudWatchLogErrorHandlerV2 - CloudWatchLogTransportServiceV2 - withCloudWatchLogTransportV2
BREAKING CHANGE: - use the new CloudWatchLogV2* classes and functions. requires the new cdk construct CloudWatchApi from @shiftcode/cdk-utils
to prevent potential mutations by reference
michaelwittwer
requested changes
Feb 2, 2026
| } | ||
|
|
||
| async writeLogs(logStreamName: string, logs: LogEvent[]): Promise<void> { | ||
| // todo: use beaconApi ? |
Member
There was a problem hiding this comment.
what's blocking from doing this now?
|
|
||
| private readonly logRequestInfoFn = inject(LOG_REQUEST_INFO_FN, { optional: true }) | ||
| private readonly config = inject(CLOUD_WATCH_LOG_V2_CONFIG) | ||
| private readonly jsonStringifyReplacer = this.config.jsonStringifyReplacer || jsonMapSetStringifyReplacer |
michaelwittwer
previously approved these changes
Feb 4, 2026
michaelwittwer
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #76
Before Merging:
@shiftcode/logger